[Return] [Catalog]

1 Admin ## SysOP 2019-10-09T00:08:00 [ImgOps] [iqdb]
File: 1382755333735.jpg (JPEG, 354.38KB, 800x800)
Please use this thread to report bugs and give feedback. You may also start a thread on >>>/meta/, even though it's not an official board we will most likely still see it.
Feel free to also report issues directly on our GitLab:
https://gitlab.com/ison2/kotatsu
»
205 Anonymous 2021-02-28T23:40:26
You are using get-image-dimensions on the fullthumb on the "((FLAC M4A MKV MP3 MP4 OCTET OGG WAV WMA WEBM) ; Audio/Video/Octet-streams" branch
https://github.com/ECHibiki/Kotatsu-V-archived/blob/d953444684870b8c01d19b72f733db739ff42b07/prv/modules/imageboard.scm#L893
instead of get-video-dimensions on the fullpath.
https://github.com/ECHibiki/Kotatsu-V-archived/blob/d953444684870b8c01d19b72f733db739ff42b07/prv/modules/utils.scm#L107
As a result video posts show the thumbnail dimensions instead of the video dimensions.
https://4taba.net/thread/a/215#5p
> 150x113

»
206 Anonymous 2021-03-01T10:56:36

scheme@(guile-user)> (use-modules (srfi srfi-1))
scheme@(guile-user)> (define options (string-split "nonoko sage" #\space))
scheme@(guile-user)> options
$1 = ("nonoko" "sage")
scheme@(guile-user)> (define sage (lset-intersection equal? '("sage" "SAGE" "さ げ" "下げ") options))
scheme@(guile-user)> sage
$2 = ("sage")
scheme@(guile-user)> (define nokosage (member "nokosage" options))
scheme@(guile-user)> nokosage
$3 = #f
scheme@(guile-user)> (define sage-dbarg (or nokosage sage))
scheme@(guile-user)> sage-dbarg
$4 = ("sage")
scheme@(guile-user)> (define name "Anonymous")
scheme@(guile-user)> (define sage sage-dbarg)
scheme@(guile-user)> (if (or (not sage)
(null? sage)
(equal? (car sage) "nokosage"))
name
(format #f "<a class=''sage'' href=''mailto:~a''>~a</a>" (car sage) name))
$5 = "<a class=''sage'' href=''mailto:sage''>Anonymous</a>"
scheme@(guile-user)>

https://github.com/ECHibiki/Kotatsu-V/blob/cb5e6779821f0b3c919e2565e089a0901da2b3f8/prv/modules/imageboard.scm#L813
https://github.com/ECHibiki/Kotatsu-V/blob/cb5e6779821f0b3c919e2565e089a0901da2b3f8/prv/modules/imageboard.scm#L960
https://github.com/ECHibiki/Kotatsu-V/blob/cb5e6779821f0b3c919e2565e089a0901da2b3f8/prv/modules/database-calls.scm#L165
»
207 Anonymous 2021-03-03T00:06:26
4taba has sage, but it's much easier to leave it disabled because I only spend 10 minutes a day here.

Along with how there's no report functionality, means that it's safest to leave subposts as the sage-like posting method.
V 2021-03-03T00:10:52
Another thing to consider is that 4taba with sage would mean that the site would look exceptionally inactive and not having it gives the site a bit more life, while taking away from the archive like nature that present 4taba has.
V 2021-03-03T00:06:47
Signed Verniy
»
208 Anonymous 2021-03-03T10:57:31
>>207
So the code running on the site is not the one on github?
»
209 Anonymous 2021-03-03T16:13:44
we'll see
»
210 Anonymous 2021-03-03T16:27:31
The thing is that the code is not made to further kotatsu as a project but meet the issue of easier moderation. I suppose if this is a concern I can make another repo for 4taba and one for kotatsu..

https://github.com/ECHibiki/Kotatsu-V/blob/master/prv/modules/imageboard.scm
»
211 Anonymous 2021-03-03T20:42:52
>>210
> to further kotatsu as a project

You can also further kotatsu with this fix: >>205
»
212 Anonymous 2021-03-03T23:40:04
I'll look at what you're suggesting. I'm updating a bunch of bio stuff right now, but I've hit a good milestone on kissu to fix some issues here.

I branched off the difference between what's ideally runable and my modifications for taba.
https://github.com/ECHibiki
»
213 Anonymous 2021-03-04T00:20:44
>>212
Since you already have
> (define-public noko-enabled #f)

in settings.scm why not add a sage-enabled and control sage/nokosage in save-post with a conditional:
(sage (if sage-enabled (lset-intersection equal? '("sage" "SAGE" "さげ" "下げ") options) '()))

and similarly for nokosage. Also note that the negative return of member is #f rather than '().

And you have
> (define-public greeting "Shitaba Ni Yokouso<br/>")

in settings.scm
https://github.com/ECHibiki/Kotatsu-V/blob/cb5e6779821f0b3c919e2565e089a0901da2b3f8/prv/modules/settings.scm#L12
but the word is Youkoso (ようこそ). Your u is misplaced.
»
214 Anonymous 2021-04-01T20:17:12
Did you remove sage?
»
215 Anonymous 2021-04-06T23:27:53
>>214
https://github.com/ECHibiki/Kotatsu-V/commit/9329c62bbac254aeab6a4b3acc447e49d8329e18
https://github.com/ECHibiki/Kotatsu-V/blob/9329c62bbac254aeab6a4b3acc447e49d8329e18/prv/modules/imageboard.scm#L852
»
216 Anonymous 2021-08-25T10:13:10 [ImgOps] [iqdb]
File: iqdb-patch.txt (text/x-diff, 1.63KB, #f)
Here's a patch that adds iqdb links next to ImgOps links.
»
217 Anonymous 2021-08-25T18:27:29
I'll review it today and add it
»
218 Anonymous 2021-08-25T20:17:36
lgtm
»
219 Anonymous 2021-08-26T09:41:26 [ImgOps] [iqdb]
File: 9530446a342042bfed1a439101e60f… (JPEG, 1.57MB, 3532x5000)
>>217 >>218
Thanks for adding.
»
220 Anonymous 2021-09-29T10:17:12
>>216
Doesn't the imgops link already have iqdb in it?
»
221 Anonymous 2021-10-01T09:38:47
>>220
+ The separate iqdb link uses the thumbnail so you don't have to wait for the full image to transfer like for imgops when all you want is reverse lookup.
+ The iqdb link inside imgops is in a place that is not immediately obvious to those who don't regularly use imgops, and it takes a second or two to scan for it, so the separate iqdb link provides convenience of access. To me the convenience of access was high enough to justify putting in the time to write and submit the patch.
»
222 Anonymous 2021-10-20T20:54:05
test #2
Anonymous 2021-10-20T20:55:51
subtest
Anonymous 2021-10-20T20:51:28
test
»
223 Anonymous 2021-10-20T21:00:33
> subpost creation before post exists
> 20:51:28 test

> 20:54:05 test #2

> 20:55:51 subtest


much keks
»
224 Anonymous 2021-10-21T01:00:39
predictive posting
»
225 Anonymous 2021-10-21T09:43:56
>>224
It's the lack of a check for (string->number (car subpost)) throughout save-post in imageboard.scm.
»
226 Anonymous 2021-10-22T01:44:04
>>225
It's not a bug. It's a feature
»
227 Anonymous 2021-10-31T12:30:53 [ImgOps] [iqdb]
File: image.png (PNG, 632.32KB, 1059x2500)
A copy of thread 2 on the meta index sporting the title of thread 92.
»
228 Anonymous 2021-12-23T12:41:21 [ImgOps] [iqdb]
File: catalog-link-patch.txt (text/x-diff, 2.23KB, #f)
I can't go directly to the catalog from a thread because there's no link, so I have to go through the board index every time. Here's a patch that adds a [Catalog] link to templates.scm:thread-tpl next to the [Return] link, using the same let approach as board-tpl. The custom order you had in thread-tpl between mod-bar-tpl and [Return] wasn't touched.
»
229 Anonymous 2021-12-23T18:33:49
won''t add it today or tomorrow, but I'll put it in.

Also remember that 4taba2 expires today and there will only be 4taba.net
»
230 Anonymous 2022-01-02T06:55:30
>>228
thanks, done
https://github.com/ECHibiki/Kotatsu-V/commit/8c0f8342d3fc4039c8f4cdfe8e94cdb292041a44#diff-98111d687d56a2521c586f4eb2de0690faef4a5a3047f1c9b88e331f40e0e6ba
»
231 Anonymous 2022-01-02T10:57:01 [ImgOps] [iqdb]
File: e4444d2bec6dec2d45bdf60346229a… (JPEG, 10.35MB, 3900x6500)
>>230
Gracias.
Anonymous 2022-01-02T17:10:49
Why is this image so blurry despite weighting 10 whole megabytes?
»
232 Anonymous 2022-01-06T20:08:57
I'm performing backups to eventually do a server reinstall. I'll give some heads up so the site isn't down unexpectedly.
Anonymous 2022-01-07T09:10:20
Site updates through email would give some greater visibility, I think
»
233 Anonymous 2022-01-11T07:18:02
Tons of text turned into question marks.
»
235 Anonymous 2022-01-11T07:31:09
backup is also before what I wanted. Did a backup before I wiped, but someone uploaded something that was tripping my antivirus causing me issues. Should have checked the filedates.

The ???? aren't due to corruption
https://puu.sh/IBU4f/c7c07c5ec6.png
just language pack issues. I want to finish off enabling the last two services and then I'll correct it. ?
»
236 Anonymous 2022-01-11T13:24:09
think i had this issue two years back when I first set up the server. Unicode works perfectly fine on everything else but Guile or Artanis is getting confused.

It may be the Guile database interface since the ???????? title at the top of the page renders fine. Suggesting that it's either the thing getting the information for templates rather than the templates themselves.
»
239 Anonymous 2022-01-11T16:54:28
I give up on getting this to work with sqlite. I'm migrating the data to mysql
»
240 Anonymous 2022-01-11T17:36:23
Nevermind, I got it. I seem to have remembered how I fixed it somewhat subconciously
»
241 Anonymous 2022-01-11T17:37:49
I guess I'll add to the github that these steps will probably need to be followed on an ubuntu server installation
https://askubuntu.com/questions/770309/cannot-permanently-change-locale-on-16-04-server
»
242 Anonymous 2022-01-12T20:42:06
I have a messure to account for the 500 errors that got removed on reinstall
»
243 Anonymous 2022-01-27T10:26:19 [ImgOps] [iqdb]
File: taba-board-link-patch.txt (text/x-diff, 1.09KB, #f)
The current "Board link" lambda of imageboard.scm:comment-filter
https://github.com/ECHibiki/Kotatsu-V/blob/f8b77f52ae2220cd9db3f3dc6191fec70191bcb1/prv/modules/imageboard.scm#L597
has at least these problems: >>>/test/48/26
+ the board name part will run over spaces and linefeeds due to "[^/]+"
+ the extra character at the end will be pulled inside the link text, breaking up html entities like &quot;
+ the behavior at the end of the string is inconsistent due to the unconditional "(- (string-length (match:substring m)) 1)" in the let*

Here's a patch that fixes these issues:
+ the board name part no longer accepts spaces and linefeeds
+ the extra character at the end goes after the closing tag where it belongs, preserving html entities
+ the behavior at the end of the string is made consistent using match:substring 1

Tests to verify the change are attached to the next post. I also think that code segments should be exempt from things like link markup, but fixing that would be a lot more work.
»
244 Anonymous 2022-01-27T10:29:35 [ImgOps] [iqdb]
File: taba-board-link-test.txt (text/html, 1.26KB, #f)
Here are the tests:
1. the old way runs over spaces and breaks html entities
2. the fix preserves html entities by placing the extra character at the end correctly after the closing tag
3. the fix doesn't accept spaces
4. the fix works consistently at the end of the string
»
245 Anonymous 2022-01-29T10:02:35
>>243
that's a strange oversight
>has at least these problems

yeah
»
248 Anonymous 2022-02-13T07:25:46
>>244 >>243
ok, this is on my agenda now
I have to reinstall linux though
»
249 Anonymous 2022-02-15T02:12:02
>>243
Resolved,

Site has also been updated to use Guile 3.0.5, DBI 2.1.8, Artanis 0.5.1 which have a few breaking changes.
Most notably the database insertion doesn't seem to work the same way anymore. Guile related.
Ports seemed to be getting appended to POST operations due to uri-path now not actually being the uri-path anymore(it was never actually a uri path anyways?). Artanis related.
URLs for image files changed to remove /pub/. Should have been like this in the first place.
Otherwise unimportant.
Anonymous 2022-02-15T02:12:46
So, since the software has been updated there may be a few 500 errors around that I haven't seen.
»
250 Anonymous 2022-02-15T12:36:22 [ImgOps] [iqdb]
File: notimage-test-patch.txt (text/x-diff, 3.07KB, #f)
>>249
>Resolved,

Thanks.

Since your post has iqdb with no image I think the thumb test in templates.scm:iqdb-tpl needs the same new test as imgops-tpl. Since the test changed several times, it might as well be factored out so it can be controlled from one place.

As a bit of trivia, you made all your static png, html and similar files executable; just making sure you're aware.
»
253 Anonymous 2022-02-15T20:58:04
Have to switch it back on the repository. it's 664 on the live. Yes, posts without files are no longer being given a boolean from the DB writter, and I'm not motivated read into why this is so I'm writting null strings instead of #f
»
254 Anonymous 2022-02-15T23:08:35
Also archive.4taba seems to be having some issues. Could have been in January or yesterday. I'll see about fixing it tonight.
Anonymous 2022-02-16T00:44:13
was nginx configuration
»
255 Anonymous 2022-02-17T11:55:26 [ImgOps] [iqdb]
File: video-size-patch.txt (text/x-diff, 873.0B, #f)
You're getting thumbnail dimensions in >>>/test/39/38 due to >>205.
»
256 Anonymous 2022-04-28T03:50:41 [ImgOps] [iqdb]
File: boardlist-catalogs-patch.txt (text/x-diff, 775.0B, #f)
I find myself wanting to switch to another listed board's catalog, but I keep having to go through the board's index page first, or having to edit the board name in the address bar, which gets tedious. It would be more convenient for me if the board list provided catalog links as well.

Here's a patch to add unobtrusive catalog links to div#top-nav, in addition to the existing index links.
»
257 Anonymous 2022-04-28T15:58:27 [ImgOps] [iqdb]
File: fa140cbe35ca9eb573f8a6c2bf999d… (JPEG, 281.45KB, 804x850)
Can something be done about the spam please?
»
258 Anonymous 2022-04-28T18:49:45
>>257
I can try two things. As long as it doesn't pile up though.

>>256
Doesn't look too obtrusive
»
259 Anonymous 2022-05-02T10:24:29
cloudflare's maximum settings reduce the spam from 10 hits per day to 3
»
260 Anonymous 2022-05-03T09:51:16
Now lets see what happens with cloudflare set to "essentially off"
»
261 Anonymous 2022-05-04T01:21:58
>>260
Looks like cloudflare has a massive impact on simple spam bots. Alternative solution will require false post fields

[Return] [Catalog]
Delete Post:
OptionsPassword
Name
Comment
File